Skip to content

BDMS-217: make lexicon read-only via API by deprecating modification endpoints#225

Merged
jirhiker merged 2 commits into
stagingfrom
BDMS-217-Make-Lexicon-Read-only-via-API
Nov 4, 2025
Merged

BDMS-217: make lexicon read-only via API by deprecating modification endpoints#225
jirhiker merged 2 commits into
stagingfrom
BDMS-217-Make-Lexicon-Read-only-via-API

Conversation

@jirhiker

@jirhiker jirhiker commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • the lexicon.json is the single source of truth for ocotillo controlled vocabulary. However it is use from a data integrity perspective to also have the lexicon terms/categories in the database to provide constraints.

How

Implementation summary - the following was changed / added / removed:

  • make all patch, post, delete routes as deprecated
  • add the disabled_endpoint dependency
  • skipped all lexicon tests involving patch, post, delete

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

@jirhiker jirhiker changed the title fix: make lexicon read-only via API by deprecating modification endpoints BDMS-217: make lexicon read-only via API by deprecating modification endpoints Nov 4, 2025
@codecov-commenter

codecov-commenter commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
api/lexicon.py 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
tests/test_lexicon.py 45.54% <100.00%> (-35.58%) ⬇️
api/lexicon.py 70.11% <83.33%> (-21.65%) ⬇️

... and 2 files with indirect coverage changes

jacob-a-brown
jacob-a-brown reviewed Nov 4, 2025
View reviewed changes
Comment thread api/lexicon.py Outdated
@jirhiker jirhiker merged commit 94530c4 into staging Nov 4, 2025
6 checks passed
@jirhiker jirhiker deleted the BDMS-217-Make-Lexicon-Read-only-via-API branch December 3, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacob-a-brown jacob-a-brown jacob-a-brown approved these changes
@chasetmartin chasetmartin Awaiting requested review from chasetmartin
@ksmuczynski ksmuczynski Awaiting requested review from ksmuczynski

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jirhiker @codecov-commenter @jacob-a-brown